fix - graceful shutdown #1242
fix - graceful shutdown #1242
Conversation
ghost
requested a review
from 
|
As a sidenote: I'm still not sure why calling |
|
|
||
| // attempt a graceful shutdown if we are not running tests | ||
| if flag.Lookup("test.v") == nil { | ||
| frankenphp.Shutdown() |
There was a problem hiding this comment.
This cannot work because in case of reload, Caddy starts the new module before stopping the old one.
There was a problem hiding this comment.
Oh I think I get it now. There's an experimental caddy.Exiting() api that we could maybe use instead.
Is there also a way to reload Caddy outside of tests? Running curl "http://localhost:2019/load" via the admin API also doesn't work on main.
There was a problem hiding this comment.
Nvm I realized you have to actually patch the whole config for a reload
curl "http://localhost:2019/config/apps/frankenphp" -X PATCH --header "Content-Type: application/json" -d '{"workers"
:[{"file_name":"/go/src/app/testdata/index.php","watch":["./**/*.{php,yaml,yml,twig,env}"]}]}' -H "Cache-Control: must-revalidate"
This works now with the Exiting() check if you're fine with using an experimental api. Otherwise I'll close this PR.
There was a problem hiding this comment.
You can use --force if you're using caddy reload or equivalent, which is the same as passing the Cache-Control: must-revalidate header in the API to reload even if the config text has not changed.
|
Could you please rebase? |
# Conflicts: # frankenphp.go
|
Thanks! |
4 participants
This PR fixes #1226 by calling
frankenphp.Shutdown()onCaddy's Shutdown().I also went ahead and replaced the
CaddyUsagePool by a global boolean. It's probably simpler to just haveShutdown()do nothing if FrankenPHP is not running (unless I'm missing something).